Introduce caching for functional routing #29985
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the functional API does not support any kind of caching for resources. I was trying to replicate an nginx setup with multiple virtual hosts, each having their own assets folder.
So my code would contain something like:
With this setup, I saw no option to define any kind of caching for these resources, because
ResourceHandlerFunction
was returning anEntityResponse
which could not be modified.This PR introduces caching support for the
.resources
instruction. Implementing theResourceCacheLookupStrategy
interface allows for either defining a general caching rule (e.g. max-age=60 for all resources), or to define custom cache behaviour per file (e.g. max-age=3600 if resource is an xml file).The default behaviour, if no strategy is provided, is to not cache at all, preserving the status quo.
I have signed the CLA