Use String.equals() in LiteralPathElement #30138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
yuzawa-san
force-pushed
the
LiteralPathElement-string-equals
branch
from
5388fc8
to
d50525d
Compare
sbrannen
added
in: web
poutsma
removed
the
status: waiting-for-triage
|
I changed the PR to remove the I then ran our JMH |
poutsma
added a commit
that referenced
this pull request
Mar 22, 2023
…quals * gh-30138: Polish external contribution Use String.equals() in LiteralPathElement
mdeinum
pushed a commit
to mdeinum/spring-framework
that referenced
this pull request
Jun 29, 2023
This commit removes the text char[] in favor of the text String introduced through the PR. Closes spring-projectsgh-30138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.equals() eventually calls StringLatin1.equals() which uses processor-specific intrinsics. They are available for major architectures and typically use some sort of processor-optimized vector operations, which should be faster than the current for-loop.
Before:
After:
