Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClient based ClientHttpRequestFactory #30478

Closed
wants to merge 1 commit into from
Closed

HttpClient based ClientHttpRequestFactory #30478

wants to merge 1 commit into from

Conversation

mdeinum
Copy link
Contributor

@mdeinum mdeinum commented May 11, 2023

As JDK17 is now the baseline it is possible to use the HttpClient provided by Java.

@mdeinum
HttpClient based ClientHttpRequestFactory
366e600 
As JDK17 is now the baseline it is possible to use the
HttpClient provided by Java.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 11, 2023
@vpavic vpavic mentioned this pull request Jun 20, 2023
Closed
@poutsma poutsma self-assigned this Jun 20, 2023
@poutsma poutsma added this to the 6.1.0-M2 milestone Jun 28, 2023
@poutsma poutsma added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 28, 2023
@poutsma poutsma closed this in 0033eb4 Jun 28, 2023
poutsma added a commit that referenced this pull request Jun 28, 2023
@poutsma
Merge pull request #30478 from mdeinum:http-client
dd57ec9 
* gh-30478:
  Polishing external contribution
  HttpClient based ClientHttpRequestFactory
@poutsma
Copy link
Contributor

poutsma commented Jun 28, 2023 •
edited
Loading

Thank for your submitting this PR, @mdeinum. I made several changes to the PR.

  • Removed duplicate Client in types names, to mirror the reactive versions in org.springframework.http.client.reactive.
  • Removed request buffering in favor of an OutputStream to Flow.Publisher<ByteBuffer> bridge, see OutputStreamPublisher. Thank you, @OlegDokuka!
  • Made request and response types package private, similar to other request and response types in the package.
  • Various other small improvements.

mdeinum pushed a commit to mdeinum/spring-framework that referenced this pull request Jun 29, 2023
@poutsma @mdeinum
Polishing external contribution
b8a8b63 
- Removed duplicate Client in types names.
- Removed buffering in favor of OutputStream to
  Flow.Publisher<ByteBuffer> bridge.
- Made request and types package private.
- Various other small improvements.

Closes spring-projectsgh-30478
@poutsma poutsma mentioned this pull request Jul 20, 2023
Closed
@alexcrownus
Copy link

JdkClientHttpRequestFactory is not compatible with BufferingClientHttpRequestFactory #31027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdeinum @poutsma @alexcrownus @spring-projects-issues