Allows JdkClientHttpRequest.DISALLOWED_HEADERS to be customized. #30788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does this by reading the System property `jdk.httpclient.allowRestrictedHeaders` and removing those set from the default list. Fixes spring-projectsgh-30787
spring-projects-issues
added
the
status: waiting-for-triage
spencergibb
commented
Jun 30, 2023
| TreeSet<String> headers = new TreeSet<>(String.CASE_INSENSITIVE_ORDER); | ||
| headers.addAll(Set.of("connection", "content-length", "expect", "host", "upgrade")); | ||
|
|
||
| String headersToAllow = System.getProperty("jdk.httpclient.allowRestrictedHeaders"); |
There was a problem hiding this comment.
Maybe there is a setter somewhere and we set the property rather than trying to read it?
spencergibb
commented
Jun 30, 2023
| @@ -48,8 +51,19 @@ class JdkClientHttpRequest extends AbstractStreamingClientHttpRequest { | |||
| * The JDK HttpRequest doesn't allow all headers to be set. The named headers are taken from the default | |||
| * implementation for HttpRequest. | |||
| */ | |||
| private static final List<String> DISALLOWED_HEADERS = | |||
| List.of("connection", "content-length", "expect", "host", "upgrade"); | |||
| protected static final Set<String> DISALLOWED_HEADERS = getDisallowedHeaders(); | |||
There was a problem hiding this comment.
protected was changed to test without much setup.
There was a problem hiding this comment.
AbstractMockWebServerTests dispatch for /echo checks that Host is localhost:port, so unsure how to test otherwise.
poutsma
added
in: web
poutsma
added a commit
that referenced
this pull request
Jul 3, 2023
* gh-30788: Polishing external contribution Allow customization of disallowed JdkClientHttpRequest headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does this by reading the System property
jdk.httpclient.allowRestrictedHeadersand removing those set from the default list.Fixes gh-30787