Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @RSocketExchange for responding #30936

Conversation

OlgaMaciaszek
Copy link
Contributor

Fixes gh-29240.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 24, 2023
@rstoyanchev rstoyanchev self-assigned this Jul 25, 2023
@rstoyanchev rstoyanchev added this to the 6.1.0-M4 milestone Jul 25, 2023
@rstoyanchev rstoyanchev added in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 25, 2023
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the documentation, while it is logical to mention @RSocketExchange alongside @MessageMapping, I'm not sure I like the result. It gets repetitive and becomes a distraction.

I think it would be better to create a dedicated section under "Annotated Responders" called @RSocketExchange, probably right after @MessageMapping where we can properly explain all that needs explaining. For a start what it is in contrast to @MessageMapping (with a reference to the RSocket Service section), that it is is supported for responding as an alternative to @MessageMapping so you can essentially use it for requesting and responding, that it supports very similar but slightly different method signature as it needs to remain neutral to requester vs responder, and so on. The RSocket Service proxy section could also mention that the annotation is supported for responding to make sure that it's discoverable. Other than that I don't think we need to mention it everywhere alongside @MessageMapping. This will become even more obvious with the same changes for @HttpExchange since we have much more extensive documentation that mentions @RequestMapping many times.

@rstoyanchev rstoyanchev changed the title Support RSocketExchange for annotated responders. Support @RSocketExchange for annotated responders Jul 28, 2023
@rstoyanchev rstoyanchev changed the title Support @RSocketExchange for annotated responders Support @RSocketExchange for responding Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support @RSocketExchange for annotated responders
3 participants