Consolidate HTTP Interface client support for MultipartFile and @RequestPart
#31164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitrii Bocharov <bdshadow@gmail.com>
spring-projectsgh-31139 Signed-off-by: Dmitrii Bocharov <bdshadow@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
in: web
rstoyanchev
changed the title
@RequestPart
rstoyanchev
requested changes
Sep 8, 2023
There was a problem hiding this comment.
Thanks for the pull request. Indeed, as we merge the two into one, we would no longer need MultipartFileArgumentResolver and since it is not yet released, it can be removed, and likewise the test classes should also be merged into one.
Would you like to apply those changes?
|
@rstoyanchev yes, i will do it |
…tArgumentResolverTests Signed-off-by: Dmitrii Bocharov <bdshadow@gmail.com>
rstoyanchev
pushed a commit
that referenced
this pull request
Sep 11, 2023
Also add test with Optional parameter for a RequestPart argument. See gh-31164 Signed-off-by: Dmitrii Bocharov <bdshadow@gmail.com>
rstoyanchev
added a commit
that referenced
this pull request
Sep 11, 2023
|
This is now merged, thanks for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the ticket, I've merged
MultipartFileArgumentResolverinto theRequestPartArgumentResolver. I also think this is a better option since the javadoc for@RequestPartexplicitly mentions work with theMultipartFile.However, I'm unsure if
MultipartFileArgumentResolvermust be removed now. Probably it can, since the release 6.1 isn't out yet, so it's present only in the pre-releases.