DefaultFetchSpec should not buffer results in temporary list buffers #31282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid fetching and buffering results in temporary `List` buffers. Signed-off-by: Ronny Perinke <23166289+sephiroth-j@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
sephiroth-j
changed the title
singleOrEmpty() instead of buffer()singleOrEmpty() instead of buffer(2) for FetchSpec.one()
snicoll
added
type: bug
snicoll
changed the title
singleOrEmpty() instead of buffer(2) for FetchSpec.one()
snicoll
pushed a commit
that referenced
this pull request
Sep 26, 2023
This commit avoids fetching and buffering results in temporary `List` buffers. See gh-31282
snicoll
added a commit
that referenced
this pull request
Sep 26, 2023
sephiroth-j
deleted the
feature/flux-singleOrEmpty-in-DefaultFetchSpec
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid fetching and buffering results in temporary
Listbuffers.I stumbled across this while analyzing a problem with oracle-r2dbc and thought that using
buffer()is unnecessary when you could usesingleOrEmptyinstead.