Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in JmsAccessor#setSessionAcknowledgeMode #31328

Closed
wants to merge 1 commit into from
Closed

Fix regression in JmsAccessor#setSessionAcknowledgeMode #31328

wants to merge 1 commit into from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Sep 27, 2023

This commit partially reverts 3b8dd0a, which introduced a strict validation in JmsAccessor#setSessionAcknowledgeMode that prevents use of vendor-specific acknowledge modes.

See also:

@vpavic
Fix regression in JmsAccessor#setSessionAcknowledgeMode
f57ec3e 
This commit partially reverts 3b8dd0a, which introduced a strict
validation in JmsAccessor#setSessionAcknowledgeMode that prevents use
of vendor-specific acknowledge modes.
@vpavic vpavic mentioned this pull request Sep 27, 2023
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 27, 2023
@snicoll snicoll added in: messaging Issues in messaging modules (jms, messaging) type: regression A bug that is also a regression and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 29, 2023
@snicoll snicoll added this to the 6.1.0-RC1 milestone Sep 29, 2023
@snicoll snicoll self-assigned this Sep 29, 2023
@snicoll snicoll mentioned this pull request Sep 29, 2023
Closed
16 tasks
snicoll pushed a commit that referenced this pull request Sep 29, 2023
@vpavic @snicoll
Fix regression in JmsAccessor#setSessionAcknowledgeMode
11c2cde 
This commit partially reverts 3b8dd0a, which introduced a strict
validation in JmsAccessor#setSessionAcknowledgeMode that prevents use
of vendor-specific acknowledge modes.

See gh-31328
snicoll added a commit that referenced this pull request Sep 29, 2023
@snicoll
Polish "Fix regression in JmsAccessor#setSessionAcknowledgeMode"
95e6902 
See gh-31328
@snicoll snicoll closed this in 9e144af Sep 29, 2023
@snicoll
Copy link
Member

snicoll commented Sep 29, 2023

Thanks again @vpavic

@vpavic vpavic deleted the fix-jms-ackmode-setter branch September 29, 2023 06:47
e-freni pushed a commit to e-freni/spring-framework that referenced this pull request Sep 29, 2023
@vpavic @enrico-freni-jaewa
Fix regression in JmsAccessor#setSessionAcknowledgeMode
47adf6d 
This commit partially reverts 3b8dd0a, which introduced a strict
validation in JmsAccessor#setSessionAcknowledgeMode that prevents use
of vendor-specific acknowledge modes.

See spring-projectsgh-31328
e-freni pushed a commit to e-freni/spring-framework that referenced this pull request Sep 29, 2023
@snicoll @enrico-freni-jaewa
Polish "Fix regression in JmsAccessor#setSessionAcknowledgeMode"
5b674f3 
See spring-projectsgh-31328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
in: messaging Issues in messaging modules (jms, messaging) type: regression A bug that is also a regression
Projects
None yet
Milestone
6.1.0-RC1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vpavic @snicoll @spring-projects-issues