Add missing unit tests for SimpleAliasRegistry
#31348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
type: task
sbrannen
changed the title
SimpleAliasRegistry
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Oct 3, 2023
2 tasks
Indeed, it's a bit tricky at first glance.
It is... except that I determined that some of the tests involving Mockito are flaky. 🤔 @e-freni, since you submitted this PR, would you be interested in getting to the bottom of the flaky test you created? |
|
@sbrannen sure, go ahead and assign me the issue |
I unfortunately cannot assign it to you; however, I've added a comment to make people aware that you plan to address it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've understood the purpose of that inversion (it took me a little while, to be honest :) ), so I've created a new pull request just for the code coverage. I hope everything is okay this time.