Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated JdbcClient.update to enable returning generated keys when using named parameters and Oracle DB. #31608

Closed
wants to merge 1 commit into from
Closed

Updated JdbcClient.update to enable returning generated keys when using named parameters and Oracle DB. #31608

wants to merge 1 commit into from

Conversation

zakaria-shahen
Copy link
Contributor

Updated JdbcClient.update to enable returning generated keys when using named parameters and Oracle DB.
issue: #31607

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 14, 2023
@jhoeller
Copy link
Contributor

I ended up introducing an update(KeyHolder generatedKeyHolder, String... keyColumnNames) variant which supports both indexed and named parameters (even if it is more likely to be used with named parameters) which I'm about to commit against #31607, just in time for the 6.1 GA release tomorrow.

Thanks for the PR, in any case!

@jhoeller jhoeller closed this Nov 15, 2023
@jhoeller jhoeller added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zakaria-shahen @jhoeller @spring-projects-issues