Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Spliterator of underlying collection in MutablePropertyValues / MutablePropertySources #32281

Conversation

kilink
Copy link
Contributor

@kilink kilink commented Feb 15, 2024

Delegate to the spliterator method of the underyling collection in MutablePropertyValues and MutablePropertySources. In both cases, those collection types have specialized Spliterator implementations. Delegating to these Spliterators also means the characteristics of the Spliterator are properly set.

Note: this spliterator was already exposed via the stream() method, since that would delegate to the underlying collection. This mostly just makes things consistent.

…utablePropertySources

Delegate to the spliterator method of the underyling collection in MutablePropertyValues and
MutablePropertySources. In both cases, those collection types have specialized Spliterator implementations. Delegating to these Spliterators also means the characteristics of the Spliterator are
properly set.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 15, 2024
Copy link

@jdicke jdicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 16, 2024
@snicoll snicoll self-assigned this Feb 16, 2024
@snicoll snicoll added this to the 6.1.5 milestone Feb 16, 2024
snicoll pushed a commit that referenced this pull request Feb 16, 2024
Delegate to the spliterator method of the underlying collection in
MutablePropertyValues and MutablePropertySources. In both cases, those
collection types have specialized Spliterator implementations.
Delegating to these Spliterators also means the characteristics of the
Spliterator are properly set.

See gh-32281
snicoll added a commit that referenced this pull request Feb 16, 2024
@snicoll snicoll closed this in 26ca7c4 Feb 16, 2024
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed type: task A general task labels Feb 16, 2024
@kilink kilink deleted the mutable-property-values-spliterator branch March 15, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants