Use ConcurrentHashMap.newKeySet where feasible
#32294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In places where a ConcurrentHashMap was used as a set by wrapping it with Collections.newSetFromMap, switch to just using the set returned by ConcurrentHashMap.newKeySet directly.
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: core
snicoll
removed
the
status: waiting-for-triage
sbrannen
reviewed
Feb 21, 2024
| @@ -16,7 +16,6 @@ | |||
|
|
|||
| package org.springframework.beans.factory.support; | |||
|
|
|||
| import java.util.Collections; | |||
There was a problem hiding this comment.
Surprise: I just noticed that 902e570 introduced additional usage of java.util.Collections, so the code no longer compiles when merged into main.
Though fret not: I'll add the import back locally. 😉
sbrannen
added a commit
that referenced
this pull request
Feb 21, 2024
|
This has been merged into Thanks |
sbrannen
changed the title
ConcurrentHashMap.newKeySet where feasible
izeye
added a commit
to izeye/spring-boot
that referenced
this pull request
Apr 29, 2024
izeye
added a commit
to izeye/spring-boot
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In places where a ConcurrentHashMap was used as a set by wrapping it with Collections.newSetFromMap, switch to just using the set returned by ConcurrentHashMap.newKeySet directly.