Fix Javadoc @since tag for ChannelRegistration.executor()
#32524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Although that's true, it was actually introduced in 6.1.4 with the wrong parameter type. So, perhaps #32129 should have been backported to Let's see what the rest of the team thinks. |
sbrannen
changed the title
@since tag for ChannelRegistration.executor()
|
That's not accurate. It was introduced this way on purpose to facilitate the migration from 6.1.x to 6.2.x, that is with the executor term but taking a |
snicoll
added
type: task
snicoll
pushed a commit
that referenced
this pull request
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature for the
ChannelRegistration.executor()has been changed in f526b23, but its Javadoc@sincetag update seems to have been missed.See gh-32129