Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for hasHttpHandlerDecorator method #32900

Closed
wants to merge 1 commit into from
Closed

Add test cases for hasHttpHandlerDecorator method #32900

wants to merge 1 commit into from

Conversation

gdmrw
Copy link

@gdmrw gdmrw commented May 26, 2024

Improve coverage

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 26, 2024
@snicoll
Copy link
Member

snicoll commented May 27, 2024

Thanks for the PR but hasHttpHandlerDecorator is trivial and the tests here consist of setting something on the builder and asserting it has been set. While it does indeed increase coverage, those tests do not bring a lot of value on their own.

@snicoll snicoll closed this May 27, 2024
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gdmrw @snicoll @spring-projects-issues