Allow HTTP and WebSocket To Use The Same Path #30
Comments
bclozel
added a commit
that referenced
this issue
Feb 2, 2021
Prior to this commit, the WebSocket endpoint (MVC or WebFlux) would be enabled by default. In the case of MVC, the presence of `spring-websocket` and the required dependencies was an additional hint that could enable/disable this support depending on the application. This commit changes the websocket path configuration so that it doesn't hold a default value anymore. Configuring this property will trigger the WebSocket support. Right now developers cannot configure it to be the same as the `spring.graphql.path`, but this will be solved in #30. This commit also revisits the configuration properties namespace for clarity, moving the websocket bits under their own section. Closes gh-31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we use a separate path property for WebSocket with a default of
"/graphql/websocket"to avoid a collision with GET"/graphql"for GraphiQL. However this shouldn't be necessary. Given the WebSocketHandlerMappingis ordered ahead, we can make it skip requests that aren't a WebSocket upgrade.The text was updated successfully, but these errors were encountered: