Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Interface for GraphQL Request Execution #42

Closed
rstoyanchev opened this issue Apr 8, 2021 · 0 comments
Closed

Add Interface for GraphQL Request Execution #42

rstoyanchev opened this issue Apr 8, 2021 · 0 comments
Assignees
@rstoyanchev
Labels
type: enhancement A general enhancement
Milestone
1.0.0-M1

Comments

@rstoyanchev
Copy link
Contributor

Currently HTTP handlers for Spring MVC and WebFlux expect a GraphQL instance and a List<WebInterceptor>. This allows for interception of requests but not for replacing or mocking out the invocation of GraphQL.
@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Apr 8, 2021
@rstoyanchev rstoyanchev added this to the 0.1.0 milestone Apr 8, 2021
@rstoyanchev rstoyanchev self-assigned this Apr 8, 2021
rstoyanchev added a commit that referenced this issue Apr 8, 2021
@rstoyanchev
Add GraphQLRequestHandler
b378231 
See gh-42
rstoyanchev added a commit that referenced this issue Apr 9, 2021
@rstoyanchev
Revise GraphQLRequestHandler
4a18932 
Rename to GraphQLService to make it more clear it is a layer below
the specific transport such as HTTP endpoints.

Add WebGraphQLService sub-interface for query execution in web
environment with a WebInterceptor chain.

See gh-42
rstoyanchev added a commit that referenced this issue Apr 9, 2021
@rstoyanchev
WebInput minor refactoring
ddf107f 
Use getters so the base RequestInput is usable for JSON serialization,
e.g. for the testing support.

Remove WebSocketMessageInput which only had an extra requestId and
add that to WebInput instead.

See gh-42
rstoyanchev added a commit that referenced this issue Apr 9, 2021
@rstoyanchev
WebOutput minor updates
b35e5f8 
Rename "headers" to "responseHeaders" and clarify those work for HTTP
request queries but not for queries over a WebSocket session.

Update getter for response headers to return a read-only wrapper.

Provide only one public constructor without headers.

See gh-42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.0.0-M1
Development

No branches or pull requests
1 participant
@rstoyanchev