Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add response headers to WebOutput #6

Closed
andimarek opened this issue Sep 27, 2020 · 1 comment
Closed

Add response headers to WebOutput #6

andimarek opened this issue Sep 27, 2020 · 1 comment
Assignees
@rstoyanchev
Labels
type: enhancement A general enhancement
Milestone
1.0.0-M1

Comments

@andimarek
Copy link
Contributor

andimarek commented Sep 27, 2020 •
edited by rstoyanchev

Sometimes you want to add additional custom response headers to the HTTP Response. WebOutput should support this.
@rstoyanchev
Copy link
Contributor

Indeed WebOutput would be a good place to expose response HttpHeaders for customization, symmetrical to WebInput. However on the WebMvc.fn side there is a shortcoming that doesn't allow this.

I've created spring-projects/spring-framework#25828. In the mean time we can proceed with adding HttpHeaders to WebOutput. Initially it will only work on WebFlux.fn and once the referenced issue is resolved we'll support it for WebMvc.fn as well.

@rstoyanchev rstoyanchev self-assigned this Sep 28, 2020
@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Sep 28, 2020
rstoyanchev added a commit that referenced this issue Oct 7, 2020
@rstoyanchev
Upgrade to Spring Boot 2.4 snapshots
cf1e3ce 
in order to make use of a recent change for WebMvc.fn in
Spring Framework 5.3.

See gh-6
rstoyanchev added a commit that referenced this issue Oct 7, 2020
@rstoyanchev
Polishing WebOutput
d4b9c47 
See gh-6
rstoyanchev added a commit that referenced this issue Oct 7, 2020
@rstoyanchev
Support for response headers through WebOutput
7eafec2 
See gh-6
@bclozel bclozel added this to the 0.1.0 milestone Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.0.0-M1
Development

No branches or pull requests
3 participants
@bclozel @rstoyanchev @andimarek