Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ResourceAssembler to accept a params Map #615

Open
williamstw opened this issue Aug 9, 2017 · 1 comment
Open

Allow ResourceAssembler to accept a params Map #615

williamstw opened this issue Aug 9, 2017 · 1 comment

Comments

@williamstw
Copy link

It'd be nice if ResourceAssembler toResource[s] method allowed a Map<String,?> to be passed in with the entity to support more complex link creation. This would allow for creating links nicely with linkTo(Class controller, Map parameters). E.g.

D toResource(T entity, Map<String,?> params)

Without it, it seems we either need to create an instance of the ResourceAssembler each time so that we can get the params in or post process (e.g. with a ResourceProcessor). I'm happy to submit a pull request if this is something of interest?

On a side note... is there a mailing list where such things are discussed beforehand? and... thanks for Spring HATEOAS!

@gregturn
Copy link
Contributor

gregturn commented Aug 9, 2017

Glad you like it.

As to altering the API I'll have to research that.

Regarding naiiing list, there is none. We do most design through issues discussions and our internal Slack. When it reaches 1.0, that might be a good time to open a Gitter channel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants