Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize AbstractCorrelatingMessageHandler Lock Keys [INT-2758] #6735

Open
spring-operator opened this issue Sep 19, 2012 · 2 comments
Open

Comments

@spring-operator
Copy link
Contributor

spring-operator commented Sep 19, 2012

Gary Russell opened INT-2758 and commented

Currently, in order to accommodate the fact the JDBC Message Store uses a UUID representation of the group Id, the ACMH has to use the UUIDConverter to obtain the id of the lock for the group.

This is because the reaper only has the UUID, and not the original group key (correlation id).

When refactoring the JDBC message store to retain the original group key, ensure that the ACMH is also changed, to gain the optimization.


This issue is a sub-task of #6647

Issue Links:

@joshiste
Copy link
Contributor

I wonder if that's still on the roadmap. Using the UUIDConverter all over the place is also bad for performance reasons:
When not passing in a UUID, every time it internally throws an exception to detect invalid UUIDs.
Creating stack traces is an expensive operation to do.

@artembilan
Copy link
Member

@joshiste ,

we have done the fix for that UUIDConverter: 77d8dfd.

The fix has nothing to do with this issue.

Thank you for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants