TcpNioClientConnectionFactory should implements SchedulingAwareRunnable [INT-3628]

[spring-operator]

Jakub Štiller opened INT-3628 and commented

Currently TcpNioClientConnectionFactory implements only Runnable interface. The thread created in the start() method is long lived and should live as long the TcpNioClientConnectionFactory is used. On WebLogic server we got warning that the thread is possible stuck as it reach configured timeout parameter.

TcpNioClientConnectionFactory should implements SchedulingAwareRunnable interface and return true for isLongLived() method (or to have this parameter configurable).

Currently only solution we found is to create sublass of standard TcpNioClientConnectionFactory that implements SchedulingAwareRunnable. But that is not nice soluton. After that we even cannot use TcpConnectionFactoryFactoryBean to create the TcpNioClientConnectionFactory.

---

Affects: 4.1.2

Referenced from: pull request #1390

[spring-operator]

Jakub Štiller commented

Thanks for fix, will wait for 4.2 release.