Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GH-753: Close transactional producer on error
Fixes #753 Improve exception handling for producer transaction commit / rollback * Close the producer if an exception is thrown while committing / rollbacking a transaction when synchronizing the Kafka transaction with another TransactionManager. * Don't reuse transactional producers if an exception is thrown when committing / rollbacking a transaction. Some of the exceptions are fatal and mean the producer cannot be reused. * Close the transactional producer if an exception occurs when calling beginTransaction when not using DefaultKafkaProducerFactory.
- Loading branch information
1 parent
63472ce
commit ac34b28
Showing
5 changed files
with
212 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
105 changes: 105 additions & 0 deletions
105
...st/java/org/springframework/kafka/support/transaction/ResourcelessTransactionManager.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /* | ||
| * Copyright 2017-2018 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.kafka.support.transaction; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| import org.springframework.transaction.TransactionDefinition; | ||
| import org.springframework.transaction.TransactionException; | ||
| import org.springframework.transaction.support.AbstractPlatformTransactionManager; | ||
| import org.springframework.transaction.support.DefaultTransactionStatus; | ||
| import org.springframework.transaction.support.TransactionSynchronizationManager; | ||
|
|
||
| @SuppressWarnings("serial") | ||
| public class ResourcelessTransactionManager extends AbstractPlatformTransactionManager { | ||
|
|
||
| @Override | ||
| protected void doBegin(Object transaction, TransactionDefinition definition) throws TransactionException { | ||
| ((ResourcelessTransaction) transaction).begin(); | ||
| } | ||
|
|
||
| @Override | ||
| protected void doCommit(DefaultTransactionStatus status) throws TransactionException { | ||
| if (logger.isDebugEnabled()) { | ||
| logger.debug("Committing resourceless transaction on [" + status.getTransaction() + "]"); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| protected Object doGetTransaction() throws TransactionException { | ||
| Object transaction = new ResourcelessTransaction(); | ||
| List<Object> resources; | ||
| if (!TransactionSynchronizationManager.hasResource(this)) { | ||
| resources = new ArrayList<>(); | ||
| TransactionSynchronizationManager.bindResource(this, resources); | ||
| } | ||
| else { | ||
| @SuppressWarnings("unchecked") | ||
| List<Object> stack = (List<Object>) TransactionSynchronizationManager.getResource(this); | ||
| resources = stack; | ||
| } | ||
| resources.add(transaction); | ||
| return transaction; | ||
| } | ||
|
|
||
| @Override | ||
| protected void doRollback(DefaultTransactionStatus status) throws TransactionException { | ||
| if (logger.isDebugEnabled()) { | ||
| logger.debug("Rolling back resourceless transaction on [" + status.getTransaction() + "]"); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| protected boolean isExistingTransaction(Object transaction) throws TransactionException { | ||
| if (TransactionSynchronizationManager.hasResource(this)) { | ||
| List<?> stack = (List<?>) TransactionSynchronizationManager.getResource(this); | ||
| return stack.size() > 1; | ||
| } | ||
| return ((ResourcelessTransaction) transaction).isActive(); | ||
| } | ||
|
|
||
| @Override | ||
| protected void doSetRollbackOnly(DefaultTransactionStatus status) throws TransactionException { | ||
| } | ||
|
|
||
| @Override | ||
| protected void doCleanupAfterCompletion(Object transaction) { | ||
| List<?> resources = (List<?>) TransactionSynchronizationManager.getResource(this); | ||
| resources.clear(); | ||
| TransactionSynchronizationManager.unbindResource(this); | ||
| ((ResourcelessTransaction) transaction).clear(); | ||
| } | ||
|
|
||
| private static class ResourcelessTransaction { | ||
|
|
||
| private boolean active = false; | ||
|
|
||
| public boolean isActive() { | ||
| return active; | ||
| } | ||
|
|
||
| public void begin() { | ||
| active = true; | ||
| } | ||
|
|
||
| public void clear() { | ||
| active = false; | ||
| } | ||
|
|
||
| } | ||
| } |