Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Mapping Types" code snippet #1226

Closed
justinbaur opened this issue Sep 4, 2019 · 2 comments
Closed

Fix "Mapping Types" code snippet #1226

justinbaur opened this issue Sep 4, 2019 · 2 comments

Comments

@justinbaur
Copy link
Contributor

The return type of mapping types code snippet does not match method signature and JsonSerializer parameter type misspelled.

@Bean
public ProducererFactory<Foo, Bar> kafkaProducerFactory(KafkaProperties properties,
    JsonSserializer customSerializer) {

    return new DefaultKafkaConsumerFactory<>(properties.buildProducerProperties(),
        customSerializer, customSerializer);
}
@artembilan
Copy link
Member

Contribution is welcome!

Please, open the Pull Request with an appropriate change and we will continue discussion over there.

Thank you for heads up!

@justinbaur
Copy link
Contributor Author

I have the issue updated in my fork was just adding for transparency and linking to PR. Thanks!

artembilan pushed a commit that referenced this issue Sep 26, 2019
Fixes #1226
# Conflicts:
#	src/reference/asciidoc/kafka.adoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants