Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BinaryExceptionClassifier to DefaultAfterRollbackProcessor #1260

Closed
Rajh opened this issue Oct 3, 2019 · 0 comments · Fixed by #1263
Closed

Add BinaryExceptionClassifier to DefaultAfterRollbackProcessor #1260

Rajh opened this issue Oct 3, 2019 · 0 comments · Fixed by #1263
Assignees
@garyrussell
Milestone
2.3.1

Comments

@Rajh
Copy link

Rajh commented Oct 3, 2019

Hi,

BinaryExceptionClassifier has been added to SeekToCurrentErrorHandler but I think the same behavior could be required in DefaultAfterRollbackProcessor ?
@garyrussell garyrussell added this to the 2.3.1 milestone Oct 3, 2019
@garyrussell garyrussell self-assigned this Oct 4, 2019
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Oct 4, 2019
@garyrussell
spring-projectsGH-1260: Add exception classification to DARP
b09bfaa 
Resolves spring-projects#1260

Refactor common code with `SeekToCurrentErrorHandler` into
`FailedRecordProcessor` super class.
@garyrussell garyrussell mentioned this issue Oct 4, 2019
Merged
artembilan pushed a commit that referenced this issue Oct 4, 2019
@garyrussell @artembilan
GH-1260: Add exception classification to DARP
457e63a 
Resolves #1260

Refactor common code with `SeekToCurrentErrorHandler` into
`FailedRecordProcessor` super class.

* Polishing to address PR comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
None yet
Projects
None yet
Milestone
2.3.1
Development

Successfully merging a pull request may close this issue.

GH-1260: Add exception classification to DARP garyrussell/spring-kafka
2 participants
@Rajh @garyrussell