Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset retry state in recoverer of SeekToCurrentErrorHandler #1547

Closed
larsduelfer opened this issue Jul 27, 2020 · 0 comments · Fixed by #1548
Closed

Reset retry state in recoverer of SeekToCurrentErrorHandler #1547

larsduelfer opened this issue Jul 27, 2020 · 0 comments · Fixed by #1548

Comments

@larsduelfer
Copy link

Based on the question I asked on stackoverflow and Garys answer it would be helpful in certain scenarios to be able to reset the retry state in the recoverer of the SeekToCurrentErrorHandler.

Currently, when an exception is raised in the recoverer, the BackOffExecution always returns the stop value. This way, no further back off is applied once the initial set of retries are exhausted and the recoverer "failed" by rasining an exception.

For further description on what I achieved by using the retry template, please see:
https://stackoverflow.com/questions/63068587/spring-kafka-how-to-replace-retry-template-with-new-backoff-and-recoverer-of-se

This could be replaced by the SeekToCurrentErrorHandler, a recoverer and the new BackOff parameter, just missing the reset of the retry state.

@garyrussell garyrussell self-assigned this Jul 27, 2020
@garyrussell garyrussell added this to the 2.6.M1 milestone Jul 27, 2020
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 27, 2020
Resolves spring-projects#1547

It generally makes sense to repeat the back offs after a recovery failure
instead of attempting recovery immediately on the next delivery.

Add an option to revert to the previous behavior.
artembilan pushed a commit that referenced this issue Jul 27, 2020
Resolves #1547

It generally makes sense to repeat the back offs after a recovery failure
instead of attempting recovery immediately on the next delivery.

Add an option to revert to the previous behavior.

* Fix code typos in docs
artembilan pushed a commit that referenced this issue Jul 27, 2020
Resolves #1547

It generally makes sense to repeat the back offs after a recovery failure
instead of attempting recovery immediately on the next delivery.

Add an option to revert to the previous behavior.

* Fix code typos in docs
# Conflicts:
#	src/reference/asciidoc/whats-new.adoc
garyrussell added a commit that referenced this issue Aug 4, 2020
garyrussell added a commit that referenced this issue Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants