Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultKafkaHeaderMapper - should allow arrays of String by default #1550

Closed
vgheo opened this issue Jul 28, 2020 · 0 comments · Fixed by #1551
Closed

DefaultKafkaHeaderMapper - should allow arrays of String by default #1550

vgheo opened this issue Jul 28, 2020 · 0 comments · Fixed by #1551
Labels
type: improvement
Milestone
2.6.M1

Comments

@vgheo
Copy link

vgheo commented Jul 28, 2020 •
edited

I'm using spring-kafka / spring-integration-kafka to implement a kafka-to-email integration.

The Spring Integration Mail requires some headers to have java.lang.String[] ( specifically, the TO field).

This all works fine on the producer and the integration service, except that the TO header field is mapped to a NonTrustedHeaderType instance.

As a work-around - customize the inboundChannelAdapter with a DefaultKafkaHeadersMapper that accepts any java type.

1/ I think it makes sense to also trust arrays of trusted types by default

2/ Would be nice to document how to configure the mapper to accept arrays of a specific type.
@garyrussell garyrussell added this to the 2.6.M1 milestone Jul 28, 2020
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 28, 2020
@garyrussell
spring-projectsGH-1550: DefaultKafkaHeaderMapper - trust arrays
bbeb84d 
Resolves spring-projects#1550

- trust arrays of trusted types (including arrays of primitive wrappers)
- trust arrays of primitives
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 28, 2020
@garyrussell
spring-projectsGH-1550: DefaultKafkaHeaderMapper - trust arrays
9ba520b 
Resolves spring-projects#1550

- trust arrays of trusted types (including arrays of primitive wrappers and String))
- trust arrays of primitives
@garyrussell garyrussell mentioned this issue Jul 28, 2020
Merged
artembilan pushed a commit that referenced this issue Jul 29, 2020
@garyrussell @artembilan
GH-1550: DefaultKafkaHeaderMapper - trust arrays
72b9dd2 
Resolves #1550

- trust arrays of trusted types (including arrays of primitive wrappers and String))
- trust arrays of primitives
garyrussell added a commit that referenced this issue Jul 29, 2020
@garyrussell
GH-1550: DefaultKafkaHeaderMapper - trust arrays
b215ca4 
Resolves #1550

- trust arrays of trusted types (including arrays of primitive wrappers and String))
- trust arrays of primitives
garyrussell added a commit that referenced this issue Jul 29, 2020
@garyrussell
GH-1550: DefaultKafkaHeaderMapper - trust arrays
af0ad5b 
Resolves #1550

- trust arrays of trusted types (including arrays of primitive wrappers and String))
- trust arrays of primitives
garyrussell added a commit that referenced this issue Jul 29, 2020
@garyrussell
GH-1550: DefaultKafkaHeaderMapper - trust arrays
84d3ade 
Resolves #1550

- trust arrays of trusted types (including arrays of primitive wrappers and String))
- trust arrays of primitives
garyrussell added a commit that referenced this issue Jul 29, 2020
@garyrussell
GH-1550: Polish test
069924c
garyrussell added a commit that referenced this issue Jul 29, 2020
@garyrussell
GH-1550: Polish test
dee102f
garyrussell added a commit that referenced this issue Jul 29, 2020
@garyrussell
GH-1550: Polish test
045b1d0
garyrussell added a commit that referenced this issue Jul 29, 2020
@garyrussell
GH-1550: Polish test
ab63fec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: improvement
Projects
None yet
Milestone
2.6.M1
Development

Successfully merging a pull request may close this issue.

GH-1550: DefaultKafkaHeaderMapper - trust arrays garyrussell/spring-kafka
2 participants
@garyrussell @vgheo