Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmbeddedKafka.partitions() is ignored in EmbeddedKafkaCondition #1563

Closed
doffid opened this issue Aug 14, 2020 · 0 comments
Closed

EmbeddedKafka.partitions() is ignored in EmbeddedKafkaCondition #1563

doffid opened this issue Aug 14, 2020 · 0 comments
Assignees
@garyrussell
Labels
backport 2.3.x (obsolete) backport 2.4.x (obsolete) backport 2.5.x (obsolete) type: bug
Milestone
2.6.RC1

Comments

@doffid
Copy link

doffid commented Aug 14, 2020

Affects Version(s): 2.5.5.RELEASE

馃悶 Bug report

When using @EmbeddedKafka annotation in a plain junit 5 test (w.o. spring-test) the partitions() attribute of the annotation is igonred, and always defaults to 2.
The problem seems in EmbeddedKafkaCondition.createBroker() where embedded.partitions() is not passed to the constructor of EmbeddedKafkaBroker
@garyrussell garyrussell self-assigned this Aug 14, 2020
@garyrussell garyrussell added this to the 2.6.M2 milestone Aug 14, 2020
garyrussell added a commit that referenced this issue Aug 14, 2020
@garyrussell
GH-1563: Fix JUnit5 @EmbeddedKafka.partitions()
a52f2fe 
Resolves #1563

Paritions property ignored in the JUnit5 condition.
garyrussell added a commit that referenced this issue Aug 14, 2020
@garyrussell
GH-1563: Fix JUnit5 @EmbeddedKafka.partitions()
cca897b 
Resolves #1563

Paritions property ignored in the JUnit5 condition.
garyrussell added a commit that referenced this issue Aug 14, 2020
@garyrussell
GH-1563: Fix JUnit5 @EmbeddedKafka.partitions()
313852a 
Resolves #1563

Paritions property ignored in the JUnit5 condition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
backport 2.3.x (obsolete) backport 2.4.x (obsolete) backport 2.5.x (obsolete) type: bug
Projects
None yet
Milestone
2.6.RC1
Development

No branches or pull requests
2 participants
@garyrussell @doffid