Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acknowledge.nack() commits the entire batch with a transactional BatchListener #1621

Closed
garyrussell opened this issue Nov 12, 2020 · 0 comments · Fixed by #1622
Closed

Acknowledge.nack() commits the entire batch with a transactional BatchListener #1621

garyrussell opened this issue Nov 12, 2020 · 0 comments · Fixed by #1622
Assignees
@garyrussell
Labels
backport 2.3.x (obsolete) backport 2.4.x (obsolete) backport 2.5.x (obsolete) type: bug
Milestone
2.6.4

Comments

@garyrussell
Copy link
Contributor

All records are incorrectly added to the ack list.
@garyrussell garyrussell added this to the 2.6.4 milestone Nov 12, 2020
@garyrussell garyrussell self-assigned this Nov 12, 2020
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Nov 12, 2020
@garyrussell
spring-projectsGH-1621: Fix nack() with Tx Batch Listener
cf85ef6 
Resolves spring-projects#1621

When using transactions, the remaining records in the batch after a `nack()`
were incorrectly added to the commit list.

**I will back-port - conflicts expected**
@garyrussell garyrussell mentioned this issue Nov 12, 2020
Merged
artembilan pushed a commit that referenced this issue Nov 12, 2020
@garyrussell @artembilan
GH-1621: Fix nack() with Tx Batch Listener
1c1edcf 
Resolves #1621

When using transactions, the remaining records in the batch after a `nack()`
were incorrectly added to the commit list.

**I will back-port - conflicts expected**
garyrussell added a commit that referenced this issue Nov 12, 2020
@garyrussell
GH-1621: Fix nack() with Tx Batch Listener
4892f27 
Resolves #1621

When using transactions, the remaining records in the batch after a `nack()`
were incorrectly added to the commit list.

**I will back-port - conflicts expected**
garyrussell added a commit that referenced this issue Nov 12, 2020
@garyrussell
GH-1621: Fix nack() with Tx Batch Listener
c240737 
Resolves #1621

When using transactions, the remaining records in the batch after a `nack()`
were incorrectly added to the commit list.

**I will back-port - conflicts expected**
garyrussell added a commit that referenced this issue Nov 12, 2020
@garyrussell
GH-1621: Fix test for back-port
004c919
garyrussell added a commit that referenced this issue Nov 12, 2020
@garyrussell
GH-1621: Fix test for back-port
21f511b
garyrussell added a commit that referenced this issue Nov 12, 2020
@garyrussell
GH-1621: Fix nack() with Tx Batch Listener
d368518 
Resolves #1621

When using transactions, the remaining records in the batch after a `nack()`
were incorrectly added to the commit list.

**I will back-port - conflicts expected**
garyrussell added a commit that referenced this issue Nov 12, 2020
@garyrussell
GH-1621: Fix test for back-port
ef1b322 
GH-1621: More back-ported test fixes
garyrussell added a commit that referenced this issue Nov 12, 2020
@garyrussell
GH-1621: More back-ported test fixes
724ac8a
garyrussell added a commit that referenced this issue Nov 12, 2020
@garyrussell
GH-1621: Test Polishing
19bea7f 
Remove mock debugging.
garyrussell added a commit that referenced this issue Nov 12, 2020
@garyrussell
GH-1621: Test Polishing
049ab3d
garyrussell added a commit that referenced this issue Nov 13, 2020
@garyrussell
GH-1621: Doc/Javadoc Polishing
1a1cc29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
backport 2.3.x (obsolete) backport 2.4.x (obsolete) backport 2.5.x (obsolete) type: bug
Projects
None yet
Milestone
2.6.4
Development

Successfully merging a pull request may close this issue.

GH-1621: Fix nack() with Tx Batch Listener garyrussell/spring-kafka
1 participant
@garyrussell