Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConditionalDelegatingErrorHandler #1842

Closed
garyrussell opened this issue Jun 24, 2021 · 1 comment · Fixed by #1843 or #1851
Closed

Add ConditionalDelegatingErrorHandler #1842

garyrussell opened this issue Jun 24, 2021 · 1 comment · Fixed by #1843 or #1851
Assignees
@garyrussell
Labels
type: enhancement
Milestone
2.7.4

Comments

@garyrussell
Copy link
Contributor

Delegate to different error handlers based on the exception type.

See https://stackoverflow.com/questions/68118649/how-to-process-all-messages-between-two-timestamps-with-spring-kafka/68118744#68118744
@garyrussell garyrussell added this to the Backlog milestone Jun 24, 2021
@garyrussell garyrussell self-assigned this Jun 24, 2021
@garyrussell garyrussell modified the milestones: Backlog, 2.7.4 Jun 24, 2021
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jun 24, 2021
@garyrussell
spring-projectsGH-1842: Add Conditional Delegating Error Handlers
4f98ac7 
Resolves spring-projects#1842
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jun 24, 2021
@garyrussell
spring-projectsGH-1842: Add Conditional Delegating Error Handlers
112ffb9 
Resolves spring-projects#1842
@garyrussell garyrussell mentioned this issue Jun 24, 2021
Merged
artembilan pushed a commit that referenced this issue Jun 24, 2021
@garyrussell
GH-1842: Add Conditional Delegating Error Handlers
8bcb052 
Resolves #1842

* Checkstyle fixes and polishing.

* Polishing - return after a delegate handles the error.
@garyrussell
Copy link
Contributor Author

Use assignable instead of hard equals.

@garyrussell garyrussell reopened this Jun 29, 2021
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jun 29, 2021
@garyrussell
spring-projectsGH-1843: Delegating EH - use isAssignable()
a6c5eb2 
Resolves spring-projects#1842
@garyrussell garyrussell mentioned this issue Jun 29, 2021
Merged
artembilan pushed a commit that referenced this issue Jun 29, 2021
@garyrussell @artembilan
GH-1843: Delegating EH - use isAssignable()
eab4a67 
Resolves #1842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
type: enhancement
Projects
None yet
Milestone
2.7.4
1 participant
@garyrussell