Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RetryingBatchErrorHandler #2099

Closed
garyrussell opened this issue Feb 9, 2022 · 1 comment · Fixed by #2100
Closed

Refactor RetryingBatchErrorHandler #2099

garyrussell opened this issue Feb 9, 2022 · 1 comment · Fixed by #2100
Labels
backport 2.8.x (obsolete) type: task

Comments

@garyrussell
Copy link
Contributor

garyrussell commented Feb 9, 2022 •
edited

Deprecate the error handler and refactor its functionality into a super class FallbackBatchErrorHandler.
@garyrussell garyrussell added this to the 3.0.0-M2 milestone Feb 9, 2022
@garyrussell garyrussell changed the title Deprecate RetryingBatchErrorHandler Refactor RetryingBatchErrorHandler Feb 9, 2022
@garyrussell

This comment was marked as resolved.

Sign in to view
@garyrussell garyrussell removed this from the 3.0.0-M2 milestone Feb 9, 2022
@garyrussell garyrussell reopened this Feb 9, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Feb 9, 2022
@garyrussell
spring-projectsGH-2099: Deprecate RetryingBatchErrorHandler
2a81afd 
Resolves spring-projects#2099

Similar to other legacy error handlers, deprecate this one because
its functionality is replaced by the `DefaultErrorHandler`.

Eventually move logic to `FallbackBatchErrorHandler` which is package
private.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Feb 9, 2022
@garyrussell
spring-projectsGH-2099: Deprecate RetryingBatchErrorHandler
9a6dd71 
Resolves spring-projects#2099

Similar to other legacy error handlers, deprecate this one because
its functionality is replaced by the `DefaultErrorHandler`.

Eventually move logic to `FallbackBatchErrorHandler` which is package
private.

**cherry-pick to 2.8.x**
@garyrussell garyrussell mentioned this issue Feb 9, 2022
Merged
artembilan pushed a commit that referenced this issue Feb 9, 2022
@garyrussell @artembilan
GH-2099: Deprecate RetryingBatchErrorHandler
b30e4b3 
Resolves #2099

Similar to other legacy error handlers, deprecate this one because
its functionality is replaced by the `DefaultErrorHandler`.

Eventually move logic to `FallbackBatchErrorHandler` which is package
private.

**cherry-pick to 2.8.x**
artembilan pushed a commit that referenced this issue Feb 9, 2022
@garyrussell @artembilan
GH-2099: Deprecate RetryingBatchErrorHandler
9300f7c 
Resolves #2099

Similar to other legacy error handlers, deprecate this one because
its functionality is replaced by the `DefaultErrorHandler`.

Eventually move logic to `FallbackBatchErrorHandler` which is package
private.

**cherry-pick to 2.8.x**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport 2.8.x (obsolete) type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-2099: Deprecate RetryingBatchErrorHandler garyrussell/spring-kafka
1 participant
@garyrussell