Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change APIs to use CompletableFuture Instead of ListenableFuture #2357

Closed
garyrussell opened this issue Jul 19, 2022 · 0 comments · Fixed by #2360 or #2367
Closed

Change APIs to use CompletableFuture Instead of ListenableFuture #2357

garyrussell opened this issue Jul 19, 2022 · 0 comments · Fixed by #2360 or #2367
Assignees
@garyrussell
Labels
type: enhancement
Milestone
2.9.0

Comments

@garyrussell
Copy link
Contributor

garyrussell commented Jul 19, 2022 •
edited
Loading

Spring is planning on deprecating ListenableFuture in 6.0.

spring-projects/spring-framework#27780

Add methods that use CompletableFuture to the templates and deprecate those that return ListenableFuture so we can remove them and have a clean API in 3.0.
@garyrussell garyrussell added this to the 2.9.0 milestone Jul 19, 2022
@garyrussell garyrussell self-assigned this Jul 19, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 19, 2022
@garyrussell
spring-projectsGH-2357: Switch to CompletableFuture
26d3d75 
Resolves spring-projects#2357

Spring Framework is planning to deprecate `ListenableFuture` in 6.0.

Add methods to the `KafkaOperations` (`KafkaTemplate`) that return
`CompletableFuture` instead; the `ListenableFuture` methods will be
removed in 3.0.

Provide mechanisms to ease the migration; allowing users to use
`CompletableFuture`s in this release, which will significantly reduce
the effort to switch in 3.0.

**2.9 Only; I will issue a separate PR for main**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 19, 2022
@garyrussell
spring-projectsGH-2357: Switch to CompletableFuture
c683764 
Resolves spring-projects#2357

Spring Framework is planning to deprecate `ListenableFuture` in 6.0.

Add methods to the `KafkaOperations` (`KafkaTemplate`) that return
`CompletableFuture` instead; the `ListenableFuture` methods will be
removed in 3.0.

Provide mechanisms to ease the migration; allowing users to use
`CompletableFuture`s in this release, which will significantly reduce
the effort to switch in 3.0.

**2.9 Only; I will issue a separate PR for main**
@garyrussell garyrussell mentioned this issue Jul 19, 2022
Merged
artembilan pushed a commit that referenced this issue Jul 20, 2022
@garyrussell @artembilan
GH-2357: Switch to CompletableFuture
128372f 
Resolves #2357

Spring Framework is planning to deprecate `ListenableFuture` in 6.0.

Add methods to the `KafkaOperations` (`KafkaTemplate`) that return
`CompletableFuture` instead; the `ListenableFuture` methods will be
removed in 3.0.

Provide mechanisms to ease the migration; allowing users to use
`CompletableFuture`s in this release, which will significantly reduce
the effort to switch in 3.0.

**2.9 Only; I will issue a separate PR for main**
garyrussell added a commit that referenced this issue Jul 20, 2022
@garyrussell
GH-2357: Fix Sonar Issues
295b68c
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 20, 2022
@garyrussell
spring-projectsGH-2357: Switch to CompletableFuture
933999c 
Resolves spring-projects#2357

Spring Framework is planning to deprecate `ListenableFuture` in 6.0.

Add methods to the `KafkaOperations` (`KafkaTemplate`) that return
`CompletableFuture` instead; the `ListenableFuture` methods have now
been removed in 3.0.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 20, 2022
@garyrussell
spring-projectsGH-2357: Switch to CompletableFuture
0bc521a 
Resolves spring-projects#2357

Spring Framework is planning to deprecate `ListenableFuture` in 6.0.

Add methods to the `KafkaOperations` (`KafkaTemplate`) that return
`CompletableFuture` instead; the `ListenableFuture` methods have now
been removed in 3.0.
@garyrussell garyrussell mentioned this issue Jul 20, 2022
Merged
artembilan pushed a commit that referenced this issue Jul 21, 2022
@garyrussell
GH-2357: Switch to CompletableFuture
ed6673e 
Resolves #2357

Spring Framework is planning to deprecate `ListenableFuture` in 6.0.

Add methods to the `KafkaOperations` (`KafkaTemplate`) that return
`CompletableFuture` instead; the `ListenableFuture` methods have now
been removed in 3.0.

* Remove KafkaOperations2; doc polishing.

* Fix import.
@hpoettker hpoettker mentioned this issue Jul 22, 2022
Closed
fmbenhassine pushed a commit to spring-projects/spring-batch that referenced this issue Jul 26, 2022
@hpoettker @fmbenhassine
Replace ListenableFuture with CompletableFuture
a2cf74a 
Related to spring-projects/spring-kafka#2357
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 27, 2022
@garyrussell
spring-projectsGH-2357: Remove Remaining Uses of ListenableFuture
b07e1cd 
Resolves spring-projects#2357

**main only; will issue separate PR to deprecate setters in 2.9**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 27, 2022
@garyrussell
spring-projectsGH-2357: Remove Remaining Uses of ListenableFuture
e9e4bbb 
Resolves spring-projects#2357

**main only; will issue separate PR to deprecate setters in 2.9**
@garyrussell garyrussell mentioned this issue Jul 27, 2022
Merged
artembilan pushed a commit that referenced this issue Jul 27, 2022
@garyrussell @artembilan
GH-2357: Remove Remaining Uses of ListenableFuture
eb7648a 
Resolves #2357

**main only; will issue separate PR to deprecate setters in 2.9**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 27, 2022
@garyrussell
spring-projectsGH-2357: Remove Remaining Uses of ListenableFuture
49c15d6 
Resolves spring-projects#2357

**Back-ported from main with deprecated accessors**
@garyrussell garyrussell mentioned this issue Jul 27, 2022
Merged
artembilan pushed a commit that referenced this issue Jul 27, 2022
@garyrussell @artembilan
GH-2357: Remove Remaining Uses of ListenableFuture
90c6e95 
Resolves #2357

**Back-ported from main with deprecated accessors**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
type: enhancement
Projects
None yet
Milestone
2.9.0
1 participant
@garyrussell