New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommonDelegatingErrorHandler does not check delegates compatibility correctly #3050
Milestone
Comments
antonin-arquey
added a commit
to antonin-arquey/spring-kafka
that referenced
this issue
Feb 20, 2024
…ibility validation Fixes: spring-projects#3050 Correct CommonDelegatingErrorHandler validation for delegates compatibility. Add documentation stating that delegates must be compatible with default error handler.
antonin-arquey
added a commit
to antonin-arquey/spring-kafka
that referenced
this issue
Feb 20, 2024
…ibility validation Fixes: spring-projects#3050 Correct CommonDelegatingErrorHandler validation for delegates compatibility. Add documentation stating that delegates must be compatible with default error handler.
antonin-arquey
added a commit
to antonin-arquey/spring-kafka
that referenced
this issue
Feb 20, 2024
Fixes: spring-projects#3050 Correct CommonDelegatingErrorHandler validation for delegates compatibility. Add documentation stating that delegates must be compatible with default error handler.
opened a small PR to fix the compatibility check when adding a delegate |
antonin-arquey
added a commit
to antonin-arquey/spring-kafka
that referenced
this issue
Feb 21, 2024
Fixes: spring-projects#3050 Correct CommonDelegatingErrorHandler validation for delegates compatibility. Add documentation stating that delegates must be compatible with default error handler.
sobychacko
pushed a commit
that referenced
this issue
Feb 22, 2024
Fixes: #3050 * Correct CommonDelegatingErrorHandler validation for delegates compatibility. * Add documentation stating that delegates must be compatible with the default error handler. **Auto-cherry-pick to `3.1.x`**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In what version(s) of Spring for Apache Kafka are you seeing this issue?
3.1.0
Describe the bug
When adding a new delegate to a
CommonDelegatingErrorHandler
, the check for compatibility withackAfterHandle
andseeksAfterHandling
is not performed.The following method does not check the
delegatesToCheck
but uses the currentthis.delegates.values()
which does not yet contains the new delegates:To Reproduce
Create a
CommonDelegatingErrorHandler
and add an incompatibleCommonErrorHandler
, no exception will be thrown.Expected behavior
The new delegates compatibility should be validated.
The text was updated successfully, but these errors were encountered: