MDCs are missing in logs produced by DefaultErrorHandler.

[mkoralewski]

In what version(s) of Spring for Apache Kafka are you seeing this issue?

3.1.3
In 3.1.2 works fine.

Describe the bug

For ConcurrentKafkaListenerContainerFactory we set CommonErrorHandler that you can see below:

  @Bean
  public ConcurrentKafkaListenerContainerFactory<String, SalesOrderOutbound> kafkaListenerContainerFactory(
      ConsumerFactory<String, SalesOrderOutbound> consumerFactory, DefaultErrorHandler defaultErrorHandler) {
    ConcurrentKafkaListenerContainerFactory<String, SalesOrderOutbound> factory =
        new ConcurrentKafkaListenerContainerFactory<>();

    factory.getContainerProperties().setObservationEnabled(true);
    factory.setConsumerFactory(consumerFactory);
    factory.setCommonErrorHandler(defaultErrorHandler);

    return factory;
  }

  @Bean
  public DefaultErrorHandler errorHandler() {
    BackOff fixedBackOff = new FixedBackOff(0, 0);
    return new DefaultErrorHandler(
        (consumerRecord, exception) -> log.error("Failed to process message from topic:{}. key:{}",
            consumerRecord.topic(), consumerRecord.key(), exception),
        fixedBackOff);
  }

When we use spring-kafka 3.1.2 logs produced by this handler had MDCs (traceId, spanId and one custom BaggageField). After upgrade to spring-kafka 3.1.3 MDCs are gone.

To Reproduce

Send event that will cause exception handled by errorHandler.

Expected behavior

Logs should have MDCs as before.

Sample

I'm not able to share sample now, hope that description above is enough.

[artembilan]

Looks like this is a regression after #3049.

We will look shortly what can be done.
So, looks like we have to restore the previous logic with a try..catch inside observation.observe(), but at the same time use observation.error() in the catch block.