Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for configuring custom ConsumerFactory and ProducerFactory beans when using Spring Boot is incorrect #3242

Closed
wilkinsona opened this issue May 9, 2024 · 0 comments · Fixed by #3243
Closed

Documentation for configuring custom ConsumerFactory and ProducerFactory beans when using Spring Boot is incorrect #3242

wilkinsona opened this issue May 9, 2024 · 0 comments · Fixed by #3243
Assignees
@sobychacko
Labels
backport-to-3.0.x (obsolete) for: backport-to-3.1.x status: backported status: waiting-for-triage type: bug
Milestone
3.2.0

Comments

@wilkinsona
Copy link
Member

In what version(s) of Spring for Apache Kafka are you seeing this issue?

All supported versions.

Describe the bug

Please see spring-projects/spring-boot#40174.

To Reproduce

Please see spring-projects/spring-boot#40174.

Expected behavior

The custom consumer and or producer factories are used by the default listener container when following Spring Kafka's documentation. To achieve this the documentation should be updated to define the beans as ConsumerFactory<?, ?> and ProducerFactory<?, ?>.
@wilkinsona wilkinsona mentioned this issue May 9, 2024
Open
@sobychacko sobychacko added this to the 3.2.0 milestone May 9, 2024
@sobychacko sobychacko self-assigned this May 9, 2024
sobychacko added a commit to sobychacko/spring-kafka that referenced this issue May 9, 2024
@sobychacko
spring-projectsGH-3242: Clarify docs on custom Consumer/Producer fact…
bbb4885 
…ories

Fixes: spring-projects#3242

**Auto-cherry-pick to `3.1.x` & `3.0.x`**
@sobychacko sobychacko mentioned this issue May 9, 2024
Merged
artembilan pushed a commit that referenced this issue May 9, 2024
@sobychacko
GH-3242: Clarify docs on custom Consumer/Producer factories
67bd8cf 
Fixes: #3242

**Auto-cherry-pick to `3.1.x`**
spring-builds pushed a commit that referenced this issue May 9, 2024
@sobychacko @spring-builds
GH-3242: Clarify docs on custom Consumer/Producer factories
74d3193 
Fixes: #3242

(cherry picked from commit 67bd8cf)
@spring-builds spring-builds mentioned this issue May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobychacko sobychacko

Labels
backport-to-3.0.x (obsolete) for: backport-to-3.1.x status: backported status: waiting-for-triage type: bug
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

GH-3242: Clarify docs on custom Consumer/Producer factories sobychacko/spring-kafka
3 participants
@sobychacko @wilkinsona @spring-builds