Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tangles #550

Closed
garyrussell opened this issue Feb 1, 2018 · 0 comments
Closed

Fix Tangles #550

garyrussell opened this issue Feb 1, 2018 · 0 comments
Assignees
@garyrussell
Labels
in pr
Milestone
2.2.M1

Comments

@garyrussell
Copy link
Contributor

garyrussell commented Feb 1, 2018 •
edited

listener <-> config

Move AbstractMessageListenerContainer.AckMode to config or support.

Move error handler interfaces to support.

HandlerAdapter

screen shot 2018-02-01 at 9 45 18 am
@garyrussell garyrussell added this to the 2.2.M1 milestone Feb 1, 2018
@garyrussell garyrussell self-assigned this Apr 3, 2018
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Apr 3, 2018
@garyrussell
spring-projectsGH-550: master to 2.2; fix tangles
26fe97b 
Fixes spring-projects#550

- package tangle `....listener` and `....listener.config` - remove config package
- class tangles between `ContainerProperties` and the listener containers
 - AckMode moved to properties
 - Error handler setters moved from properties to containers
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Apr 3, 2018
@garyrussell
spring-projectsGH-550: master to 2.2; fix tangles
64dd43f 
Fixes spring-projects#550

- package tangle `....listener` and `....listener.config` - remove config package
- class tangles between `ContainerProperties` and the listener containers
  - AckMode moved to properties
  - Error handler setters moved from properties to containers
@garyrussell garyrussell mentioned this issue Apr 3, 2018
Closed
denis554 added a commit to denis554/spring-kafka that referenced this issue Mar 27, 2019
@denis554
GH-550: master to 2.2; fix tangles
a5b6497 
Fixes spring-projects/spring-kafka#550

- package tangle `....listener` and `....listener.config` - remove config package
- class tangles between `ContainerProperties` and the listener containers
  - AckMode moved to properties
  - Error handler setters moved from properties to containers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
in pr
Projects
None yet
Milestone
2.2.M1
Development

No branches or pull requests
1 participant
@garyrussell