New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow injection of a CommitCallback #72

Closed

garyrussell opened this issue May 12, 2016 · 0 comments

Labels

in pr

Milestone

Contributor

garyrussell commented May 12, 2016

Default just logs.

garyrussell added this to the 1.0.0.RC1 milestone

garyrussell added the in progress label

garyrussell added a commit to garyrussell/spring-kafka that referenced this issue


          spring-projectsGH-62; commitSync() By Default

ca991e7

Fixes spring-projects#62
Resolves spring-projects#72

See the discussion on spring-projectsGH-62 `commitAsync()` is not currenly reliable.
Use `commitSync()` by default; add `syncCommits` property to the containers
(default true).

Also allow a user-injected commit callback (spring-projectsGH-72)

garyrussell added a commit to garyrussell/spring-kafka that referenced this issue


          spring-projectsGH-62; commitSync() By Default

3c56f70

Fixes spring-projects#62
Resolves spring-projects#72

See the discussion on spring-projectsGH-62 `commitAsync()` is not currenly reliable.
Use `commitSync()` by default; add `syncCommits` property to the containers
(default true).

Also allow a user-injected commit callback (spring-projectsGH-72)

garyrussell mentioned this issue

GH-62; commitSync() By Default #74

Merged

garyrussell added in pr and removed in progress labels

garyrussell added a commit to garyrussell/spring-kafka that referenced this issue


          spring-projectsGH-62; commitSync() By Default

d93d91b

Fixes spring-projects#62
Resolves spring-projects#72

See the discussion on spring-projectsGH-62 `commitAsync()` is not currenly reliable.
Use `commitSync()` by default; add `syncCommits` property to the containers
(default true).

Also allow a user-injected commit callback (spring-projectsGH-72)

artembilan closed this as completed in #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment