Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide setter method for CleanupConfig in StreamsBuilderFactoryBean #810

Closed
sobychacko opened this issue Sep 20, 2018 · 3 comments
Closed
Assignees
Milestone

Comments

@sobychacko
Copy link
Contributor

Currently, StreamsBuilderFactoryBean provides an empty constructor and allows StreamsConfig to be injected through a setter method. When doing this, there is no way currently to provide a custom CleanupConfig as setter for this is not available in StreamsBuilderFactoryBean.

@artembilan
Copy link
Member

This is what we have since version 2.2:

/**
 * Construct an instance with the supplied streams configuration and
 * clean up configuration.
 * @param streamsConfig the streams configuration.
 * @param cleanupConfig the cleanup configuration.
 * @since 2.2
 */
public StreamsBuilderFactoryBean(KafkaStreamsConfiguration streamsConfig, CleanupConfig cleanupConfig) {

Does it make sense to you? Or do you still want a setter? Then contribution is welcome!

@sobychacko
Copy link
Contributor Author

The setter for CleanupConfig is not necessary. Sorry for the noise. Closing the issue.

@adrien-ben
Copy link
Contributor

That would be great to have a setter though. I use Springboot and it would be helpful if i could inject a StreamsBuilderFactoryBeanCustomizer to set the CleanupConfig.

artembilan pushed a commit that referenced this issue Sep 30, 2020
@artembilan artembilan added this to the 2.6.2 milestone Sep 30, 2020
@artembilan artembilan self-assigned this Sep 30, 2020
garyrussell added a commit that referenced this issue Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants