Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in container.closeProducers() #881

Closed
garyrussell opened this issue Nov 19, 2018 · 0 comments
Closed

NPE in container.closeProducers() #881

garyrussell opened this issue Nov 19, 2018 · 0 comments
Labels
type: bug
Milestone
2.2.1

Comments

@garyrussell
Copy link
Contributor

See https://gitter.im/spring-projects/spring-kafka?at=5bf2adbc1ad4155d3aeb29b5
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Nov 19, 2018
@garyrussell
spring-projectsGH-881: Null check in closeProducers()
a924718 
Fixes spring-projects#881

`getAssignedPartitions()` can return `null`.
@garyrussell garyrussell mentioned this issue Nov 19, 2018
Merged
artembilan pushed a commit that referenced this issue Nov 19, 2018
@garyrussell @artembilan
GH-881: Null check in closeProducers()
7859b39 
Fixes #881

`getAssignedPartitions()` can return `null`.
artembilan pushed a commit that referenced this issue Nov 19, 2018
@garyrussell @artembilan
GH-881: Null check in closeProducers()
13fe69f 
Fixes #881

`getAssignedPartitions()` can return `null`.
artembilan pushed a commit that referenced this issue Nov 19, 2018
@garyrussell @artembilan
GH-881: Null check in closeProducers()
d6f2f4c 
Fixes #881

`getAssignedPartitions()` can return `null`.

# Conflicts:
#	spring-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java

* Add import for `@Nullable`
artembilan pushed a commit that referenced this issue Nov 19, 2018
@garyrussell @artembilan
GH-881: Null check in closeProducers()
be0cb65 
Fixes #881

`getAssignedPartitions()` can return `null`.

# Conflicts:
#	spring-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java

* Add import for `@Nullable`

# Conflicts:
#	spring-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java
@garyrussell garyrussell added this to the 2.2.1 milestone Nov 26, 2018
denis554 added a commit to denis554/spring-kafka that referenced this issue Mar 27, 2019
@denis554
GH-881: Null check in closeProducers()
6d0f999 
Fixes spring-projects/spring-kafka#881

`getAssignedPartitions()` can return `null`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
1 participant
@garyrussell