Make ZK client timeouts configurable #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyrussell
suggested changes
Feb 9, 2020
There was a problem hiding this comment.
Thanks for the contribution!
We also like to provide builder pattern methods for properties like this:
public EmbeddedKafkaBroker zkClientTimeouts(...) {...}
We should also add these properties to @EmbeddedKafkaBroker with corresponding changes in the EmbeddedKafkaContextCustomizer and the EmbeddedKafkaCondition to set the properties in the broker.
Let me know if you want to do this extra work or whether we should take it from here.
Thanks again; looking forward to more.
|
Hi @garyrussell , sure, happy to take this forward. Didn't you mean |
|
Sorry. Yes @embeddedkafka. |
Closed
artembilan
requested changes
Feb 10, 2020
spring-kafka-test/src/main/java/org/springframework/kafka/test/EmbeddedKafkaBroker.java
Outdated
Show resolved
Hide resolved
garyrussell
pushed a commit
that referenced
this pull request
Feb 10, 2020
* Make ZK client timeouts configurable * Wire ZK clients timeouts to @embeddedkafka properties * Splitting the ZK client timeout properties, @author * @SInCE on new API
|
And cherry-picked as abf2bfe to 2.3.x with deprecated Thanks again @pawellozinski |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For build servers with high load, it may happen that the build hangs for couple of seconds. This causes the internal ZK client session of embedded Kafka broker to timeout and fail the build.
It would be good if these were configurable.