GH-1828: Use consumer record's partition for @RetryableTopic #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…false Signed-off-by: Deepesh <deepeshvrm1@gmail.com>
…esolveDestination - Extract out a protected method to `resolveTopicPartition` for destination DLT - Set the partition to the same partition as the original record
|
Looks good to me, thanks! |
garyrussell
suggested changes
Jun 15, 2021
There was a problem hiding this comment.
Thanks for the contribution!
Although this is technically a breaking change (a user might have configured retry topics with only one partition) we are saved by the DLPR falling back to null for an invalid partition. (S)he'll get a bunch of warning logs, but I think the chances are small.
| : resolveTopicPartition(cr, nextDestination); | ||
| } | ||
|
|
||
| protected TopicPartition resolveTopicPartition(final ConsumerRecord<?, ?> cr, final DestinationTopic nextDestination) { |
There was a problem hiding this comment.
Needs javadoc since it's a public API.
It should explain the default resolution algorithm.
There was a problem hiding this comment.
Added javadoc. Thanks!
…Factory.resolveTopicPartition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1828
Update DeadLetterPublishingRecovererFactory#resolveDestination
resolveTopicPartitionfor destination DLTTest Changes
RetryableTopicwithautoCreate=false