Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Race in Micrometer Test #2661

Merged
merged 1 commit into from Apr 20, 2023
Merged

Conversation

garyrussell
Copy link
Contributor

@garyrussell garyrussell commented Apr 19, 2023

When timers have dynamic tags, creation of the timers is deferred until the first completion of a timer with a set of tag values.

Use awaitility to wait for the timer to be created before checking the count.

cherry-pick to 2.9.x

When timers have dynamic tags, creation of the timers is deferred until
the first completion of a timer with a set of tag values.

Use awaitility to wait for the timer to be created before checking the
count.
@garyrussell garyrussell added this to the 3.0.7 milestone Apr 19, 2023
@garyrussell garyrussell self-assigned this Apr 19, 2023
@artembilan artembilan merged commit 4d6d7f6 into spring-projects:main Apr 20, 2023
2 checks passed
@artembilan
Copy link
Member

... and cherry-picked to 2.9.x

@garyrussell garyrussell deleted the race branch May 1, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants