Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free exceptions from ConsumerAwareRebalanceListener #2887

Closed

Conversation

michaldo
Copy link
Contributor

@michaldo michaldo commented Nov 8, 2023

org.apache.kafka.clients.consumer.internals.ConsumerCoordinator has logic to handle exception thrown by rebalance listener.

firstException.compareAndSet(null, invokePartitionsAssigned(addedPartitions));

If listener throws exception, it will be called again.

Moreover, particular exceptions, like WakeupException are contracted in Javadoc.

There is no need to hide from Kafka code problems, because Kafka have policy to manage problems.

org.apache.kafka.clients.consumer.internals.ConsumerCoordinator has logic to handle exception thrown by rebalance listener.

`firstException.compareAndSet(null, invokePartitionsAssigned(addedPartitions));`

If listener throws exception, it will be called again.

Moreover, particular exception, like `
WakeupException` are contracted in Javadoc.

There is no need to hide from Kafka code problems, because Kafka have policy to manage problems.
@artembilan artembilan added this to the 3.1.1 milestone Dec 13, 2023
@sobychacko sobychacko self-assigned this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants