reuse RecordHeader in AggregatingReplyingKafkaTemplate #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanQingyangXu
force-pushed
the
reuse-correlation-header-in-aggregatingReplyingKafkaTemplate
branch
from
263cac8
to
7695889
Compare
| isBinaryCorrelation() | ||
| ? ((CorrelationKey) correlationId).getCorrelationId() | ||
| : ((String) correlationId).getBytes(StandardCharsets.UTF_8))); | ||
| done.headers().add(correlation); |
There was a problem hiding this comment.
seems regardless of whether binary format is used or not, we simply reuse the same header; also helps eliminate two casting warnings in IDE along the way.
|
Thank you for contribution; looking forward for more! |
|
Haha, stay tuned.
…On Wed, Dec 13, 2023, 10:36 a.m. Artem Bilan ***@***.***> wrote:
@NathanQingyangXu <https://github.com/NathanQingyangXu> ,
Thank you for contribution; looking forward for more!
—
Reply to this email directly, view it on GitHub
<#2932 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6UYAQL7VC7RVPK2JTDRNLYJHDPZAVCNFSM6AAAAABASQZOMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJUGE2TSMBZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
NathanQingyangXu
deleted the
reuse-correlation-header-in-aggregatingReplyingKafkaTemplate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there is some logic cleaning up room in AggregatingReplyingKafkaTemplate to reuse existing RecordHeader without duplicating it.
Not very sure about the validity of my PR. Feel free to close it if invalid.