-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AbstractMessageListenerContainer.isPaused #3016
Conversation
...kafka/src/main/java/org/springframework/kafka/listener/AbstractMessageListenerContainer.java
Show resolved
Hide resolved
...ng-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java
Show resolved
Hide resolved
...ng-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java
Show resolved
Hide resolved
I am not sure whether we should remove the |
see #609 comment about
look like same as
|
9848149
to
26d461a
Compare
Yes. I totally agree with the change. @sobychacko , I'm not sure how that |
Looks like the tests are green now. I will do another pass of the review. Don't you think the |
I think the code is now like this in this PR:
So, we are good. |
Sorry, I missed that. |
Use AbstractMessageListenerContainer method
isPauseRequested
uniformly instead ofisPaused()
.