Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish retryable topic. #3104

Conversation

Wzy19930507
Copy link
Contributor

  • add @nullable at AbstractKafkaListenerEndpoint.setGroupId
  • add @nullable at AbstractKafkaListenerEndpoint.setGroupId
  • change KafkaListenerEndpointDescriptor type to record at KafkaListenerEndpointRegistrar
  • cleanup KafkaListenerEndpointRegistry
  • change collect(Collectors.toList()) to toList() at EndpointCustomizerFactory.
  • cleanup EndpointHandlerMethod.
  • cleanup tests.

@sobychacko
Copy link
Contributor

@Wzy19930507 Several classes you modified are missing the author tag and the copyright updates. Could you take care of that?

* change `KafkaListenerEndpointDescriptor` type to `record` at `KafkaListenerEndpointRegistrar`
* cleanup `KafkaListenerEndpointRegistry`
* change `collect(Collectors.toList())` to `toList()` at `EndpointCustomizerFactory`.
* cleanup `EndpointHandlerMethod`.
* cleanup tests.
@Wzy19930507 Wzy19930507 force-pushed the polish_class_level_retryable_topic branch from 7585f2e to 438e896 Compare March 7, 2024 21:03
@sobychacko sobychacko added this to the 3.2.0-M2 milestone Mar 8, 2024
@sobychacko sobychacko merged commit 8355162 into spring-projects:main Mar 8, 2024
3 checks passed
@Wzy19930507 Wzy19930507 deleted the polish_class_level_retryable_topic branch March 8, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants