Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema initialization should execute statements individually #507

Closed
odrotbohm opened this issue Feb 20, 2024 · 0 comments
Closed

Schema initialization should execute statements individually #507

odrotbohm opened this issue Feb 20, 2024 · 0 comments
Assignees
@odrotbohm
Labels
in: event publication registry Event publication registry type: improvement Minor improvements
Milestone
1.2 M2

Comments

@odrotbohm
Copy link
Member

Currently, we're executing the content of the database schema resources in one go (via JdbcOperations.execute(…), which is only intended to execute a single statement). Some databases like HSQLDB cannot properly deal with strings containing multiple statements at once.

We should move to ResourceDatabasePopulator to actually submit the statements contained in the schema files individually.
@odrotbohm odrotbohm added in: event publication registry Event publication registry type: improvement Minor improvements labels Feb 20, 2024
@odrotbohm odrotbohm added this to the 1.2 M2 milestone Feb 20, 2024
@odrotbohm odrotbohm self-assigned this Feb 20, 2024
@odrotbohm odrotbohm mentioned this issue Feb 20, 2024
Closed
odrotbohm added a commit that referenced this issue Feb 20, 2024
@odrotbohm
GH-507 - Improve database schema initialization for event publications.
aa4b34c 
We now use ResourceDatabasePopulator to execute the schema files creating the infrastructure for the event publication registry. This makes sure that the statements in those files are executed individually.

Related ticket: GH-403.
odrotbohm added a commit that referenced this issue Feb 20, 2024
@odrotbohm
GH-403 - Polishing.
840a1b6 
Added indexes for HSQLDB (after fix for GH-507). Removed by-listener index for MySQL as it would not be used anyway. Polished index names. Disable Spring Boot banners in tests.

Original pull request: GH-411.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: event publication registry Event publication registry type: improvement Minor improvements
Projects
None yet
Milestone
1.2 M2
Development

No branches or pull requests
1 participant
@odrotbohm