Upgrade to NUnit 3.5 #134
Merged
Upgrade to NUnit 3.5 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lahma
commented
Oct 25, 2016
•
lahma
commented
- NUnit 3.5
- change NuGet package restore to follow recommended non-msbuild based restore
- disables Spring.Services testing for now as it's problematic with newer NUnit runners (now big changes in the horizon for this project)
- fixing various problems with NHibernate testing
- proved too hard to support both NUnit 2.x and 3.x with Spring.Testing, so plain upgrade
lahma
force-pushed
the
features/nunit35
branch
21 times, most recently
from
4bfddb4
to
4abfc37
Compare
* upgrade nuget.exe and use single installation in build-support directory * migrate to preferred automatic visual studio package restore mode * fix various issues with NHibernate build configuration * fix building of MVC projects when MVC libs not present
lahma
force-pushed
the
features/nunit35
branch
from
4abfc37
to
b3d1d85
Compare
lahma
changed the title
|
@sbohlen do you agree with this change? this might break for some users that use Spring.Testing.NUnit and force to upgrade to NUnit 3. But this is required when taking baby steps towards .NET Core support. I guess next version will be 2.1 if not even 3.x. I would continue from here following the steps outlined in #133 . |
|
Merged now and we can create a hotfix branch from time before this commit if needed, or branch this away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.