Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Postgres #636

Closed
dmadunic opened this issue Jun 25, 2020 · 8 comments
Closed

Add support for Postgres #636

dmadunic opened this issue Jun 25, 2020 · 8 comments

Comments

@dmadunic
Copy link

in addition to h2, Petclinic app comes with support for mysql, it would be nice to have similar support for the second (maybe first ;-)) most popular open source database Postgres.

Support can be done along the same lines as the one for mysql, namely to add the following files and folders:

  • resources/
    • application-postgres.properties
    • db/
      • postgres/
        • data.sql
        • schema.sql

And finally, posgres jdbc driver should be added to the runtime dependencies in pom.xml

I have also attached to this issue all of the above files, for review.

resources.zip
schema.sql

@arey
Copy link
Contributor

arey commented Jun 25, 2020

@dmadunic if you are interested, to prepare a Pull Request, you could look at the legacy version spring-petclinic/spring-framework-petclinic that support PostgreSQL (see the readme.md)

@dmadunic
Copy link
Author

dmadunic commented Jun 25, 2020

I think that I have already done the major part of the work, so sure I would be glad to prepare a Pull request.

I have tested it and run it locally, so it should not be much of an effort.

@arey
Copy link
Contributor

arey commented Jun 25, 2020

Ok great. Before that wait a response from @dsyer or @snicoll

@snicoll
Copy link
Member

snicoll commented Jul 6, 2020

Feel free to submit a PR and we can take it from there.

lynchmaniac added a commit to lynchmaniac/spring-petclinic that referenced this issue Dec 7, 2021
lynchmaniac added a commit to lynchmaniac/spring-petclinic that referenced this issue Dec 7, 2021
nroi added a commit to nroi/spring-petclinic that referenced this issue Dec 7, 2021
nroi added a commit to nroi/spring-petclinic that referenced this issue Dec 7, 2021
nroi added a commit to nroi/spring-petclinic that referenced this issue Dec 7, 2021
@nroi
Copy link
Contributor

nroi commented Dec 7, 2021

I'd like to revive this topic. It's been over a year since the last reply, so I hope it's ok that I just went ahead and submitted a PR.

@lynchmaniac
Copy link

@nroi what a synchronicity, I just also posted a PR too on the same subject. 😃

Cool, hoping the code is merged.

@nroi
Copy link
Contributor

nroi commented Dec 7, 2021

@lynchmaniac aah, what are the chances, after more than a year of silence, two PRs are posted just 3 minutes apart 😄

dsyer pushed a commit that referenced this issue Dec 7, 2021
@dsyer
Copy link
Member

dsyer commented Dec 10, 2021

Resolved via #878

@dsyer dsyer closed this as completed Dec 10, 2021
SergK pushed a commit to SergK/spring-petclinic that referenced this issue Jan 14, 2022
roryp referenced this issue in Azure-Samples/build2022-spring-petclinic Apr 28, 2022
hildebrandttk pushed a commit to hildebrandttk/spring-petclinic that referenced this issue May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants