Antora #462
Merged
Antora #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This defers the looking up of modifiedFiles until it is used. It also allows other tasks to be ran from the non-primary worktree. Working in another worktree is essential for Antora which will clone each branch/tag into a new worktree to process it.
This ensures the attributes are available for the docs-build branch as well.
The permission actions: write is necessary so that pushes to branches and tags can invoke the deploy-docs workflow on the docs-build branch
onobc
reviewed
Sep 25, 2023
onobc
reviewed
Sep 25, 2023
| @@ -6,7 +6,7 @@ if (gitPresent) { | |||
|
|
|||
| ext { | |||
| if (gitPresent) { | |||
| modifiedFiles = files(grgit.status().unstaged.modified).filter{ f -> f.name.endsWith('.java') } | |||
| modifiedFiles = providers.provider { files(grgit.status().unstaged.modified).filter{ f -> f.name.endsWith('.java') } } | |||
There was a problem hiding this comment.
This was in there previously but I removed as gradle build was failing on it. I thought maybe it was from Gradle 8 but did not look too much into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.