-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide http(s) default port method #347
Comments
How about |
I was thinking the same but was not sure if this might sound ambiguous (just the scheme or both) for the user. On the other hand this should be solved by a good documentation. |
That's certainly a risk. Another option would be to deprecate
The methods would set the scheme and the port. Methods that don't take an |
That might be a better idea. Just one little thing: it could be confusing to have default port 8080 and switching it to 80 by using the |
Hmm, I think that would be confusing. I think that puts that particular idea at the bottom of the list for me. Another option would be for |
This simple improvement just points out how complicated it can be to introduce such a little change. I can understand that the pro and cons put this on the bottom on the list. (deleting local branch 😁 ) |
This commit adds new methods as a shorthand for the existing ones. `withHttp` and `withHttps` allows to override the default port. See spring-projectsgh-347
It feels like a magic number to use
80
or443
in theUriConfigurer#withPort
method to suppress the port output given the right scheme.There should be a method to set this magic number without user getting to see or having to use it like
withHttpPort
orwithHttpsPort
.I know it is a small change but I think the right way is to discuss it before opening a PR.
The text was updated successfully, but these errors were encountered: