Add constructor make timeout customisable #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahlenst
force-pushed
the
timeout-constructor
branch
from
5aff957
to
40e9693
Compare
artembilan
requested changes
May 23, 2023
| private long timeout; | ||
|
|
||
| /** | ||
| * Creates a new instance with the timeout set to {@link #DEFAULT_TIMEOUT}. |
There was a problem hiding this comment.
Method Javadocs must be imperative: https://github.com/spring-projects/spring-framework/wiki/Code-Style#javadoc-formatting
|
|
||
| /** | ||
| * Creates a new instance with a configurable timeout. | ||
| * @param timeout timeout in milliseconds |
| @@ -21,6 +21,7 @@ | |||
| import org.springframework.retry.RetryContext; | |||
|
|
|||
| import static org.assertj.core.api.Assertions.assertThat; | |||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | |||
There was a problem hiding this comment.
This import is out of use.
Please, remove.
aahlenst
force-pushed
the
timeout-constructor
branch
from
40e9693
to
ea272f1
Compare
|
Problems should be resolved. |
|
Thank you for contribution; looking forward for more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a separate constructor to
TimeoutRetryPolicyto create a new instance with a configurable timeout. This follows the pattern established by other policies, for example,SimpleRetryPolicy, that allow to customise their behaviour during instance creation.